search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
413 stars 85 forks source link

Map download is not cached when using factory.load_all #80

Closed Prillan closed 11 years ago

Prillan commented 11 years ago

The map download is not cached if you load replays like this

sc2reader.load_replays(files, options={"load_map":True, "debug":True})
Prillan commented 11 years ago

I just realized that the cache maybe isn't used at all.

This should probably be stated somewhere.

GraylinKim commented 11 years ago

Hey sorry about the confusion @Prillan.

I talked to @dsjoerg and pushed a modified version of the factories we use for ggtracker into both the master and hots branches. The commit d340d3fdad59d88ac214105ce004eef08e1dea77 documents its basic use. Let me know if you have any questions, bugs, or concerns.

Please close the issue if this fits your needs.

Prillan commented 11 years ago

Looks good.