search

GraylinKim / sc2reader

A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community. Who doesn't want to hack on the games they play?
http://sc2reader.readthedocs.org
MIT License
413 stars 85 forks source link

Training matches identified as Automated Match Making #96

Open dsjoerg opened 11 years ago

dsjoerg commented 11 years ago

http://ggtracker.com/matches/1767921

>>> summary = sc2reader.load_game_summary("http://xx.depot.battle.net:1119/a1936a846c19bbec4a37217e731dbf2b71aff04c1d5d9ec423dd592809485074.s2gs")

>>> summary.settings
{'Game Mode': 'Automated Match Making', 'Lobby Delay': '10', 'Locked Alliances': 'Yes', 'Premade Game': 'Yes', 'Teams': '1 v 1', 'Rules': 'Default', 'Game Speed': 'Normal'}
dsjoerg commented 11 years ago

I bring this up mostly because this issue, if explored, might uncover some additional source of information that would be useful. It's not an urgent problem for GGTracker right now.

GraylinKim commented 11 years ago

Game mode appears to be the only attribute that addresses the "what kind of game was it" question. The only known values for it are:

      "Game Mode", 
      {
        "": "Single Player", 
        "Amm": "Ladder", 
        "Priv": "Private", 
        "Pub": "Public"
      }

It is possible this information might be stuffed into the replay.details (unlikely) or replay.initData files.

dsjoerg commented 11 years ago

This issue is about an s2gs file, not a replay file. I opened this issue in case it inspired you to find extra sources of information to distinguish between true Ladder matches and training matches. I suspect that lobby/player information will make it clear -- battlenet id of 0, probably.

GraylinKim commented 11 years ago

To be clear though, this issue of determining what mode the game was played in is also an issue for replay files. Correct?

dsjoerg commented 11 years ago

Correct.

GraylinKim commented 11 years ago

I don't believe that this is stored anywhere in current replays and s2gs files. We can adjust the replay.is_ladder flag to be false when AI players are present. It still doesn't distinguish between Ranked and Unranked ladder but it is better than nothing.

GraylinKim commented 11 years ago

I am putting this issue on indefinite hold awaiting resolution of Blizzard/s2protocol#14.