search

Grimrukh / soulstruct

Python tools for inspecting and modifying FromSoft games (mainly Dark Souls 1).
144 stars 16 forks source link

fixes #14 #15

Closed LukeLavan closed 2 years ago

LukeLavan commented 2 years ago

fixes #14

if a test raises a NoSkipOrReturnError or a NoNegateError then a temporary condition is checked out for use.

Previously, if the test was part of an Await call and a NoNegateError is raised here, there was no logic for actually Awaiting using condition 0.

I've done my best to re-write this part of the code to allow for this behavior, avoiding the behavior I documented in #14

So an event that looks like: testingallthethings successfully compiles and decompiles into expected emevd: pogchamp!!!

This is a pretty big rewriting of the code that was there previously, so please independently verify that this doesn't absolutely break everything everywhere else :^)

LukeLavan commented 2 years ago

It's been a year since I opened this issue. Since then it looks like the emevd stuff has drastically changed. I'm not sure if this issue is still present or relevant anymore, so I'm going to go ahead and close the issue and associated PR.