search

GrotjahnLab / surface_morphometrics

Morphometrics for Membrane Surfaces Segmented from Cryo-ET or other volumetric imaging.
GNU General Public License v3.0
18 stars 9 forks source link

Ensure compatibility with pymeshlab 2022.2.post3 #26

Closed m-albert closed 2 months ago

m-albert commented 2 months ago

Follow up on the discussion here https://github.com/GrotjahnLab/surface_morphometrics/issues/22#issuecomment-2192307029.

While running surface_morphometrics on a linux cluster I ran into (https://github.com/GrotjahnLab/surface_morphometrics/issues/22#issuecomment-2142666241) reported by @Kathir-66.

This PR applies the fix suggested here, which I confirm solves the problem at least in my case and leaves things unchanged with newer versions of pymeshlab.

Thanks again for this package and also for kindly accepting contributions :)

bbarad commented 2 months ago

Thanks again for upstreaming your fix! Dataset size scaling means cluster operation is a necessity, and its very valuable for me to get input from people with very different setups to make sure the software is as widely compatible as possible.