HCL-TECH-SOFTWARE / connections-automation

Deployment and upgrade automation scripts for HCL Connections 7.0 based on Ansible
Apache License 2.0
17 stars 31 forks source link

Share to MS Teams JS in wrong path #214

Closed stoeps13 closed 1 year ago

stoeps13 commented 1 year ago

I deployed the Teams integration with the project and found that the icon to share is not loading.

Reason:

Files in pv-connections/customizations

├── ms-teams
│   ├── appregistry
│   │   ├── ms-teams-collapse-sidebar.json
│   │   ├── ms-teams-itm.json
│   │   ├── ms-teams-profile-bizcard.json
│   │   └── ms-teams-share.json
│   └── customizations
│       └── ms-teams
│           ├── collapse-sidebar
│           │   ├── communities_sidebar_collapse.js
│           │   └── wikis_sidebar_collapse.js
│           └── teamsshare
│               ├── connections-teams-share-integration.js
│               └── nls
│                   ├── locale_ar.json

File path in Customizer:

            "payload": {
                "include-files": [
                    "ms-teams/teamsshare/connections-teams-share-integration.js"
                ],

So the file wants to load ms-teams/teamsshare, but the file is stored in ms-teams/customizations/ms-teams/teamsshare/

Regards Christoph

sabrina-yee commented 1 year ago

Thanks @stoeps13. I've updated the path to copy over from the extracted CP location.

stoeps13 commented 1 year ago

I haven't tested your fix @sabrina-yee, but I bet there are 3 ms-teams folder in customizations now.

I would change here: https://github.com/HCL-TECH-SOFTWARE/connections-automation/blob/main/roles/hcl/component-pack/tasks/setup_ms_teams_extensions.yml#L58

sabrina-yee commented 1 year ago

@stoeps13 the intention is to align with the original json as much as possible. This is the /pv-connections/customizations structure after I ran the change:

/pv-connections/customizations

├── container.css
├── containerUtils.js
├── helloWorld
│   └── helloWorld.user.js
├── ms-teams
│   ├── collapse-sidebar
│   │   ├── communities_sidebar_collapse.js
│   │   └── wikis_sidebar_collapse.js
│   └── teamsshare
│       ├── connections-teams-share-integration.js
│       └── nls
│           ├── locale_ar.json
│           ├── locale_ca.json
│           ├── locale_cs.json
│           ├── locale_de.json
│           ├── locale_en.json
│           ├── locale_es.json
│           ├── locale_fi.json
│           ├── locale_fr.json
│           ├── locale_he.json
│           ├── locale_it.json
│           ├── locale_ja.json
│           ├── locale_ko.json
│           ├── locale_nl.json
│           ├── locale_pl.json
│           ├── locale_pt-br.json
│           ├── locale_ru.json
│           ├── locale_th.json
│           ├── locale_zh.json
│           └── locale_zh-tw.json
stoeps13 commented 1 year ago

Ok, will try. Thanks

stoeps13 commented 1 year ago

Double checked, the change fixes the issue.