search

HCL-TECH-SOFTWARE / connections-automation

Deployment and upgrade automation scripts for HCL Connections 7.0 based on Ansible
Apache License 2.0
17 stars 30 forks source link

Checksums for Websphere download files #277

Open stoeps13 opened 1 year ago

stoeps13 commented 1 year ago

Hi,

I wanted to implement the file names as downloaded from Flexnet in my environment's variable file.

As I wasn't certain if the checksum was different, I started to read the documentation: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/get_url_module.html#parameter-checksum

The used checksums in the variables are no sha1 sums, as they are longer, the documentation tells us, that the used algorithm needs to start the string if it is no sha1. I wondered why this works and found that the parameter is checksum and not check_sum as used in the variables, there is no code in the roles which reads this check_sums value. So, it is safe to leave this away (I don't need it and no other package download is double-checked with a checksum).

This checks were removed in https://github.com/HCL-TECH-SOFTWARE/connections-automation/commit/1627079a3f94d9458201adda55fd887191fd93d6#diff-150c79a52153bd3bc7b349b544794842a18b57bd8476169490bfbff1936af6b1L18, so I recommend removing the checksum values from the variables and defaults, as they are not used at all. Or document the process to create the checksums and reimplement the check.

nitinjagjivan commented 1 year ago

Agree. Internal work item is created.