search

HCL-TECH-SOFTWARE / connections-automation

Deployment and upgrade automation scripts for HCL Connections 7.0 based on Ansible
Apache License 2.0
17 stars 32 forks source link

Oct CR4 release #318

Closed sabrina-yee closed 11 months ago

sabrina-yee commented 11 months ago
stoeps13 commented 11 months ago

Good morning, the release tag 1.1.3 states, that PR #275 is incorporated. I just checked this and would say it got even worse.

The usage of ansible_distribution got extended. In prior versions only ansible_distribution == "RedHat" was used (and still is in place). Now for ldap and haproxy for example the when formula is ansible_distribution != "RedHat"

Additionally 

roles/third_party/containerd-install/tasks/install_containerd.yml
111:   - ansible_facts['distribution'] in ['RedHat', 'AlmaLinux', 'Rocky']

roles/third_party/nginx-install/tasks/setup_os.yml
19:   - ansible_facts['distribution'] in ['RedHat', 'AlmaLinux', 'Rocky']

was added. So now CentOS or Amazon/Oracle Linux will not run this part. I would recommend to change these distribution terms to 

ansible_os_family == "Redhat"
ansible_os_family != "Redhat"

and it's filtered. No need to use different approaches.

Regards, Christoph

sabrina-yee commented 11 months ago

Thanks for the feedback @stoeps13. We'll look into it, as I believe the change was intentional to not run that step on CentOS.

pln-git4011 commented 11 months ago

Hi Christoph, Thank you for the feedback. This PR was reviewed by the squad, and it was determined that the change would cause internal test deployments to fail. A number of internal VMs have been switched to AlmaLinux but there are still CentOS 7 VMs used internally, and this change would cause failures on those VMs.

stoeps13 commented 11 months ago

Hi, Yes inerpreted like this.

So combine with ansible_os_family == RedHat and ansible_distribution != Centos and it fits again.