HCL-TECH-SOFTWARE / connections-automation

Deployment and upgrade automation scripts for HCL Connections 7.0 based on Ansible
Apache License 2.0
17 stars 31 forks source link

Hardcoded Plugin path in Docs deployment #337

Closed stoeps13 closed 3 weeks ago

stoeps13 commented 1 month ago

You can change the Plugin install directory with plg_install_location, but the propagate task in docs does use hardcoded path:

https://github.com/HCL-TECH-SOFTWARE/connections-automation/blob/d135841f579833b946b0ac8bd5fbfaf6eaf64cad/roles/hcl/docs/tasks/propagate_plugin.yml#L9-L12

This should be changed to something like

- name:                 "Copy the files to {{ __plg_install_location }}/config/"
  copy:
    src:                "/tmp/wct_generated_plugins_docs_{{ inventory_hostname_short }}/plugin-cfg.xml"
    dest:               "{{ __plg_install_location }}/config/{{ inventory_hostname_short }}/plugin-cfg.xml"
    remote_src:         yes

Additionally the vars/main.yml needs a new entry for

__plg_install_location: "{{ plg_install_location | default('/opt/IBM/WebSphere/Plugins') }}"
sabrina-yee commented 1 month ago

@stoeps13 thanks for the suggestion, related change will be merged once reviewed.