HEP-FCC / k4RecCalorimeter

Key4hep Framework Components for the Calorimeter Reconstruction
2 stars 18 forks source link

fix crash due to wrong treatment of pointers in ONNX-related code, and remove one photon-ID variable from decorations when not needed #108

Closed giovannimarchiori closed 2 months ago

giovannimarchiori commented 2 months ago

Pointers were not treated correctly in some cases and led to a crash, see discussion in https://github.com/……HEP-FCC/k4RecCalorimeter/pull/104#discussion_r1735675543

Also, one shape parameter for photon ID was being added to clusters even when the flag for adding photon-id related variables was false.

This PR fixes both things

tmadlener commented 2 months ago

@kjvbrt or @BrieucF can you press the necessary buttons to merge this, if you are happy as well.