HEP-FCC / k4RecCalorimeter

Key4hep Framework Components for the Calorimeter Reconstruction
2 stars 18 forks source link

fix metadata of topoclusters #118

Closed giovannimarchiori closed 3 weeks ago

giovannimarchiori commented 3 weeks ago

The topoclustering algorithm adds a shape parameter to the output cluster collection (https://github.com/HEP-FCC/k4RecCalorimeter/blob/b571f7c49595b4b99f98857ef54014658cb51abc/RecFCCeeCalorimeter/src/components/CaloTopoClusterFCCee.cpp#L225) but it does not declare it in the metadata information of the clusters. Downstream algorithms such as AugmentClustersFCCee append metadata and shape parameters, and algorithms such as MVA calibration or photon ID look at the metadata to identify the position of the input features. The missing info in the topocluster metadata screws up the latter algorithms, as the real input features to be used are shifted by +1 with respect to what the tools extract from the metadata. This PR fixes the problem by adding proper metadata info to the topoclusters.