search

HEP-FCC / k4RecCalorimeter

Key4hep Framework Components for the Calorimeter Reconstruction
2 stars 16 forks source link

ClusterCell collection lacking cellID encondings, or including cells from heterogeneous subsystems with different CellIDEncodings #84

Open giovannimarchiori opened 3 months ago

giovannimarchiori commented 3 months ago

The clustered cell collection (https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecCalorimeter/src/components/CreateCaloClustersSlidingWindow.cpp#L45C8-L45C23) can potentially hold cells from heterogeneous subsystems which then have inconsistent CellIDEncodings. The issue and further details are extensively described and discussed in https://github.com/HEP-FCC/k4RecCalorimeter/pull/83

In addition, even if only one system is used, the cell collection attached to the cluster does not have the CellIDEncoding. This is indeed potentially a problem (analysis scripts later in the chain may need this information to properly set-up the decoder).

BrieucF commented 3 months ago

Among the two options discussed (have similar cellID encodings for the different sub-systems or having one cluster cell collection per subsystem) I would be in favor of the latter. What do you think?