issues
search
HERA-Team
/
uvtools
Tools useful for the handling, visualization, and analysis of interferometric data.
MIT License
1
stars
1
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Rather than do a loop that tests many choices of window function, this should be parametrized. It should also be broken up into multiple test functions--one that tests basic parameters (e.g. window length, type, and range), and one that tests normalization. There's certainly a way to parametrize fixtures so that you don't need to repeat code when parametrizing over windows, though I don't remember how to do it off the top of my head. Here's a quick example of one such rewrite:
#125
aewallwi
opened
3 years ago
0
These should be separate tests, e.g. ``test_calc_width_single_filter_size`` and ``test_calc_width_bandpass`` (or something to that effect).
#124
aewallwi
opened
3 years ago
0
Too many assertions.
#123
aewallwi
opened
3 years ago
0
Make these their own tests. I like to make error tests very specific, so it's obvious when things in the code have been changed. For example, suppose the function ``func`` raises a ``ValueError`` with error message ``msg`` when ran with parameters ``args``. I would then write a test along the lines of
#122
aewallwi
opened
3 years ago
0
Too many assertions for a single test.
#121
aewallwi
opened
3 years ago
0
This can be greatly simplified by use of parametrization. I'd also *strongly* recommend against running more than one ``assert`` statement per test.
#120
aewallwi
opened
3 years ago
0
Since these parameters are reused, it would make sense to make them fixtures (or global variables, but that's not as neat). As an example, you would do something like
#119
aewallwi
opened
3 years ago
0
Again with multiple assertions per test. A test should only have a single point of failure, otherwise it isn't very helpful when it comes to debugging.
#118
aewallwi
opened
3 years ago
0
Modularize pytest
#117
aewallwi
closed
3 years ago
0
Fix pytest
#116
aewallwi
closed
3 years ago
1
Create README.md
#115
aewallwi
closed
3 years ago
0
Pytest, github-actions, and codecov.
#114
aewallwi
closed
3 years ago
1
Migrate to github actions.
#113
aewallwi
closed
3 years ago
2
Build uniform grid in 1d fit
#112
aewallwi
closed
3 years ago
3
Dpss xtol
#111
aewallwi
closed
3 years ago
1
Phase wraps
#110
r-pascua
opened
3 years ago
0
Plot horizon in fourier_transform_waterfalls
#109
r-pascua
opened
3 years ago
0
Improve plot.labeled_waterfall
#108
r-pascua
opened
3 years ago
0
Handle case when user provides zero or negative filter-half-widths.
#107
aewallwi
closed
3 years ago
0
fix fundamental period bug.
#106
aewallwi
closed
3 years ago
4
speed up dayenu inverse using circulent imbedding.
#105
aewallwi
closed
3 years ago
0
CLEAN with multiple disjoint regions does not work.
#104
aewallwi
opened
3 years ago
0
Minor python3 fixes to plot_uv.py
#103
AaronParsons
closed
3 years ago
1
Fix dayenu resid
#102
aewallwi
closed
4 years ago
6
subtract weights times resid to compute dayenu model in fourier filter
#101
aewallwi
opened
4 years ago
0
Fix info return
#100
aewallwi
closed
4 years ago
1
More flexible 2d clean areas
#99
aewallwi
opened
4 years ago
0
Style enforcement
#98
aewallwi
opened
4 years ago
0
Drop old code
#97
aewallwi
closed
4 years ago
0
Rect 2d filter fit basis
#96
aewallwi
opened
4 years ago
1
add `rect` 2d filtering mode to `_fit_basis_2d`
#95
aewallwi
opened
4 years ago
0
More flexible 2dclean areas.
#94
aewallwi
opened
4 years ago
2
basemap is causing travis to fail
#93
aewallwi
closed
4 years ago
0
migrate to github actions and pytest
#92
aewallwi
closed
3 years ago
2
Set flagged residuals to zero
#91
aewallwi
closed
4 years ago
2
Break up uvtools into pipeline code and utility code
#90
aewallwi
closed
4 years ago
4
Fix fft normalization
#89
r-pascua
closed
4 years ago
2
Fix fft normalization
#88
r-pascua
closed
4 years ago
2
Extend types of data that fancy plotters can handle
#87
r-pascua
opened
4 years ago
0
Extend usability of difference plotters
#86
r-pascua
opened
4 years ago
0
Update difference plotters to use fancy plotters
#85
r-pascua
opened
4 years ago
0
Support plotting/processing subarrays in fancy plotters
#84
r-pascua
opened
4 years ago
0
Custom plot units
#83
r-pascua
closed
4 years ago
1
Handle Flagged Data in Fancy Plotters
#82
r-pascua
opened
4 years ago
0
Add Support for Custom Axis Units in Fancy Plotters
#81
r-pascua
closed
4 years ago
0
Improve Testing/CI
#80
r-pascua
opened
4 years ago
0
Import warnings in plot.
#79
r-pascua
closed
4 years ago
1
Extend utils.FFT to support 2D transforms
#78
r-pascua
opened
4 years ago
0
Improved waterfalls
#77
r-pascua
closed
4 years ago
3
fix a bug in filter factors error check.
#76
aewallwi
closed
4 years ago
2
Previous
Next