search

HW-SWeL / ShEx-validator

ShEx-validator parses a ShEx schema and RDF data file and validates the resources in the data against the shapes in the schema
MIT License
3 stars 1 forks source link

Change RDF.js passed() func to work with HCLS #17

Closed tar672 closed 9 years ago

tar672 commented 9 years ago

Very unsure about this. The line return this.matches.length > 0 && this.errors.length === 0; was there already but unreachable. Possibly need to ask Eric.

@Doix ?

Doix commented 9 years ago

Seems pretty risky to merge this. It may end up causing false positives/negatives. We should get some unit tests up and passing before we try 1 line hacks in a 4k LOC file without understanding them. That's my opinion anyway. Asking Eric seems like a good idea.

tar672 commented 9 years ago

Agree with @Doix. This should be fixed by a better solution for RDF.js