Closed janus2 closed 6 years ago
Nice work!
Would be nice if all the actions were done "live", i.e. no "Apply" button needed. This should be done in separate (multiple) thread(s) so it's not blocking the GUI for large images.
"Smooth scaling" should be a checkmark option. ShowImage shows that with the right algorithm and today's hardware this shouldn't be a problem to do live today.
Resizing without keeping the aspect ratio should limit the horizontal/vertical window size. Right now the window shows a white background, which isn't that nice.
Maybe add a bit of padding round the buttons, to uncramp the layout a bit.
Add a pop-up menu with standard sizes, see WonderBrush's "New canvas" window.
Change "As" to "Format". Add ":" to all labels.
I don't like the floating Options window too much. IMO it should always be visible and not hide when some other app has focus. It should also be resizable.
Use an rdef and add supported filetypes to get TAresizer into Tracker's "Open" menu:
resource file_types message {
"types" = "image",
"types" = "application/x-vnd.haiku-icon"
};
The list got longer and longer... :) Want me to file issues for each?
You can wait, I'll try to fix the simple issues first... after that we can open a ticket for the remaining problems.
I don't think the live update works in this application. In my opinion the apply button is very simple to use when you choose to apply a filter a number of times (when you want a darker image for example).
With regard to the used image format, it'd be even better to default to the dropped image's format, I think.
If you choose a different format and then drop an image or if you drop different images with different formats... I choose one format because the discoverability of how to save an image is not very good (a suggestion in the window will help) but if you do not select a format you cannot drag the image making the process very annoying.
resource file_types message {
"types" = "image",
"types" = "application/x-vnd.haiku-icon"
};
See my previous comment
I think this is useful for a new canvas. An image had already an aspect ratio that a standard size cannot accomodate.
"Smooth scaling" works only with shrunk images when the haiku bilinear filter works with enlarged images.
Left smooth scaling/right haiku bilinear filter
Why? The widgets are almost all buttons not need to resize the window.
After some thought, I agree with most of your assessments.
WRT to "Smooth scaling", it'd be best to transparently use the appropriate algorithm for scaling down/up, no?
The resizable "Options" window would probably only be of interest for the file name. BTW, "Filename:" would be better as label IMO.
WRT to "Smooth scaling", it'd be best to transparently use the appropriate algorithm for scaling down/up, no?
I thought about that. "Smooth scaling" now works as a filter. The image will look degraded if enlarged again. I will try to apply the filter live and see if it is not too expensive.