HarbourMasters / Shipwright

3.27k stars 489 forks source link

missing interpolation #1059

Closed briaguya-ai closed 2 years ago

briaguya-ai commented 2 years ago

during my rachael bravo playtesting, i noticed the following were missing interpolation

i feel like most of these are explained by the static function epoch pattern, but i figure having them listed here at least gives us a list of things to test

briaguya-ai commented 2 years ago

all the places using the static function var in draw funcs

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/code/z_actor.c#L3976-L3977

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/code/z_kankyo.c#L1462-L1463

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/code/z_kankyo.c#L1645-L1646

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/code/z_kankyo.c#L1928-L1929

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/code/z_lifemeter.c#L416-L417

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Bg_Spot00_Hanebasi/z_bg_spot00_hanebasi.c#L264-L265

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Fd/z_boss_fd.c#L1838-L1839

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Ganon/z_boss_ganon.c#L3359-L3360

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Ganon/z_boss_ganon.c#L3466-L3467

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Ganon/z_boss_ganon.c#L4161-L4162

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Ganon2/z_boss_ganon2.c#L2467-L2468

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Ganon2/z_boss_ganon2.c#L2640-L2641

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Ganon2/z_boss_ganon2.c#L2704-L2705

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Ganon2/z_boss_ganon2.c#L2936-L2937

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Mo/z_boss_mo.c#L2446-L2447

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Sst/z_boss_sst.c#L2709-L2710

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Tw/z_boss_tw.c#L3332-L3333

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Tw/z_boss_tw.c#L4421-L4422

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Tw/z_boss_tw.c#L4495-L4496

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Boss_Va/z_boss_va.c#L4009-L4010

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Demo_6K/z_demo_6k.c#L567-L568

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Demo_Kankyo/z_demo_kankyo.c#L525-L526

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Demo_Kankyo/z_demo_kankyo.c#L666-L667

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Demo_Kankyo/z_demo_kankyo.c#L787-L788

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Demo_Kankyo/z_demo_kankyo.c#L936-L937

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Eff_Dust/z_eff_dust.c#L272-L273

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Eff_Dust/z_eff_dust.c#L324-L325

https://github.com/HarbourMasters/Shipwright/blob/46c44cbe0244b449b0610e24676ffef8ea45478a/soh/src/overlays/actors/ovl_Fishing/z_fishing.c#L1769-L1770

jbodner09 commented 2 years ago

Not sure if this one you found or not, but the particles when spawning the rainbow bridge appear to be missing interpolation too.

briaguya-ai commented 2 years ago

created an issue for the rainbow bridge (https://github.com/HarbourMasters/Shipwright/issues/1201), i'm going to close this issue and make detailed individual issues for known problematic areas