HarbourMasters / Shipwright

3.31k stars 495 forks source link

Cosmetics Editor Code Cleanup #1543

Closed leggettc18 closed 1 year ago

leggettc18 commented 2 years ago

Cosmetics editor has a few oddly named functions and some opportunity for refactoring to reduce duplication. For instance, GetRandomValue and RandomizeColor (which is in UIWidgets.cpp) both seem to do a lot of the same tasks with slight variations, and GetRandomColorRGB sounds like it would return a ColorRGB8 value, but instead it randomizes an entire section of cosmetic items and doesn't return anything, it just edits each element in that array of elements. Need to take a good look at it and figure out what can be consolidated, and what can be moved in/out of UIWidgets.cpp.

briaguya-ai commented 1 year ago

cosmetics v3 is so fresh and so clean (clean)