Rando settings that add items to your inventory don't remove them from the pool

[jbodner09]

The two settings I tried in particular are to start with all maps and compasses, and to start with Open gerudo fortress. As you can guess by the title, I found both the gerudo pass, as well as the map and compass in deku tree (I did also have the setting to shuffle the gerudo pass turned on though).

I think this seed might have been a victim of other bugs that were fixed after it was generated, so it's also possibly not worth looking into this until we get other reports of those settings not working. In particular, #1835 and #1833 were fixed after generating this seed, and the spoiler definitely mentions a vanilla deku tree, whereas I actually had a MQ deku tree, which may be why the checks didn't line up.

In particular, if you look at the spoiler, I did NOT receive the fire arrows or nut upgrade that were supposed to be in deku (although I did get everything else promised in there). In contrast, since MQ Doodong IS in the spoiler, I noticed that I did in fact get everything in there that was promised.
06-44-72-16-43.log

[briaguya-ai]

what version were you playing on?

[jbodner09]

This was the latest dev right after the commit to add MQ dungeon support to rando was added (#1828), but before the other commits mentioned above were added, so it's quite possible those other commits already fixed what I was seeing.

[garrettjoecox]

@jbodner09 Have we determined if this was a real bug or just a quirk of the bug fixed in #1828 ?

[jbodner09]

The gerudo pass was by design, since I didn't realize it was still used to gate entrance to GTG. The dungeons not aligning with what was in the spoiler I think was fixed since I haven't been able to reproduce the issue after that fix, but the non-existence of the bug doesn't necessarily prove it's fixed.

[briaguya-ai]

i'm going to go ahead and close this for now, if it pops up again we can reopen it