search

HarbourMasters / Shipwright

3.3k stars 494 forks source link

can't buy bombs from scrub even with bomb bag (chus in logic) #2241

Open briaguya-ai opened 1 year ago

briaguya-ai commented 1 year ago

happened in the DMC scrub grotto, had bomb bag and chus, will upload spoiler later

got progressive bomb bag from botw center skulltula chest

briaguya-ai commented 1 year ago

21-81-39-78-97.json.txt

briaguya-ai commented 1 year ago

so it looks like this is an issue with the obtainability check for vanilla scrubs selling bombs

https://github.com/HarbourMasters/Shipwright/blob/a6120811d5d270a322e2ec4e9fda01b1fee65b74/soh/src/overlays/actors/ovl_En_Dns/z_en_dns.c#L282-L293

we could pass play in here and add a 64dd check, but i don't think it's a big enough issue to justify the increased complexity.

instead, i think we need some bigger cleanup around scrubs https://github.com/HarbourMasters/Shipwright/issues/2258