search

HarbourMasters / Shipwright

3.27k stars 490 forks source link

Rando : Purchasing a Big Poe Bottle wrongfully equips Mirror Shield #2589

Closed titrok0982 closed 1 year ago

titrok0982 commented 1 year ago

Buying a Big Poe Bottle from Kakariko Village's Bazaar as adult made me equip Mirror Shield, even though I never obtained it. When purchasing, it first shows a popup text (with a blue background) about the big poe, and then the next popup says "Would you like to buy something else?" but it acts as an equipment popup for mirror shield. If you press A, it equips mirror shield, and then shows the actual "Would you like to buy something else?" popup that acts properly. If you choose "No", it does not equip Mirror Shield, and proceeds to show the actual popup for buying something else.

It is important to note that I have the "Ask to Equip New Items" option enabled. Which is what I believe gets wrongfully activated when buying the bottle.

This behaviour was reproduced by others using the seed file. As far as I tested, it only occured when buying a Big Poe Bottle, not when filling another bottle with bugs at the same shop for exemple.

Steps to reproduce :

Version : Khan Alfa 6.1.0 Seed json file attached in the zip file. Video of the bug happening also attached. I have inifinite money on, but it doesn't change the behaviour to disable it. My inputs are seen on screen, and you can see there is one A button press that equips the shield instead of going back to the shop. Before the clip I did nothing special just traveling from my spawn point (Zora Shop) to the bazaar. I can provide a full video of everything I did to reproduce if that is necessary I can also provide any other information that may be useful for investigating. Clip+Json.zip

titrok0982 commented 1 year ago

The bug still appears after catching a big poe the regular way, and then buying the Big Poe Bottle at the shop. Is the "Bottle with Big Poe" item custom made for rando purposes? Then maybe the ID for the item (or for the text that shows up) gets mixed up with the ID for mirror shield?

As I have seen in z_message_PAL.c, it does seem to only show the equip popup for correct IDs, so either the fonction that allows to equip an item gets called at the wrong spot, or there is a mixup in IDs and texts somehow. I haven't investigated any further yet

Archez commented 1 year ago

With shopsanity, shops can have two bottle types: Bottle refills (for existing bottles in your inv), and a new Bottle containing something. New bottles can only be on the left side. Refills will be on the right side, but can also be on the left.

So I'm curious if this happens with all new bottles, or only new bottles that have a big poe.

briaguya-ai commented 1 year ago

looks like the ask to equip logic isn't taking non vanilla items into account

https://github.com/HarbourMasters/Shipwright/blob/dbcc6b4818c9c23791effd2787fa5b180a8d7542/soh/src/overlays/actors/ovl_player_actor/z_player.c#L12606

so when we get down to

https://github.com/HarbourMasters/Shipwright/blob/dbcc6b4818c9c23791effd2787fa5b180a8d7542/soh/src/overlays/actors/ovl_player_actor/z_player.c#L12670

anything with an RG value between

https://github.com/HarbourMasters/Shipwright/blob/dbcc6b4818c9c23791effd2787fa5b180a8d7542/soh/include/z64item.h#L153-L155

will lead to equip logic getting triggered

RG_BOTTLE_WITH_BIG_POE is 0x40 so that lines up

titrok0982 commented 1 year ago

With shopsanity, shops can have two bottle types: Bottle refills (for existing bottles in your inv), and a new Bottle containing something. New bottles can only be on the left side. Refills will be on the right side, but can also be on the left.

So I'm curious if this happens with all new bottles, or only new bottles that have a big poe.

As far as I could test, it doesn't show any bug with Bugs, Fish, Red Potion, or Empty new bottles. I believe it does depend on the specific value of the items, it is likely that Big Poe Bottles are the only conflicting ones.

briaguya-ai commented 1 year ago

https://github.com/HarbourMasters/Shipwright/blob/dbcc6b4818c9c23791effd2787fa5b180a8d7542/soh/soh/Enhancements/randomizer/randomizerTypes.h#L836-L838

i'd expect shield issues with all 3 of these

inspectredc commented 1 year ago

I tried with poe and it didnt work but perhaps it was locked out since I was adult link

briaguya-ai commented 1 year ago

I tried with poe and it didnt work but perhaps it was locked out since I was adult link

did you have a deku shield already?

titrok0982 commented 1 year ago

I tried with poe and it didnt work but perhaps it was locked out since I was adult link

did you have a deku shield already?

I'd guess the equip popup doesn't show for deku shield as adult

inspectredc commented 1 year ago

I tried with poe and it didnt work but perhaps it was locked out since I was adult link

did you have a deku shield already?

No, was itemless and just trying same as with big poe