search

HarbourMasters / Shipwright

3.18k stars 482 forks source link

MQ loser green rupees considered major for CTMC #2633

Closed aMannus closed 1 year ago

aMannus commented 1 year ago

Green rupees added to the pool by MQ dungeons are considered major for chest textures match contents. I'm assuming this is because it just looks at a green rupee to dictate that, but it should only happen with Greg (which there is only one of).

briaguya-ai commented 1 year ago

not quite, GI_RUPEE_GREEN is set to junk https://github.com/HarbourMasters/Shipwright/blob/bd07a560221bc079dda965f8564685dfcf47f4d2/soh/soh/OTRGlobals.cpp#L493 but GI_RUPEE_GREEN_LOSE is not https://github.com/HarbourMasters/Shipwright/blob/bd07a560221bc079dda965f8564685dfcf47f4d2/soh/soh/OTRGlobals.cpp#L531

briaguya-ai commented 1 year ago

greg is in the rando table https://github.com/HarbourMasters/Shipwright/blob/bd07a560221bc079dda965f8564685dfcf47f4d2/soh/soh/Enhancements/randomizer/randomizer.cpp#L5351

briaguya-ai commented 1 year ago

I'm pretty sure GI_RUPEE_GREEN_LOSE is the one used in the treasure chest game, so we should make sure to verify any fix for this doesn't trivialize that

AlxBrx commented 1 year ago

Fixed by PR #2652? If so, this should be closed