search

HarbourMasters / Shipwright

3.18k stars 482 forks source link

[No-LOD Bug] Mido Ignores No Kokiri LOD Mode on Return Trip from Great Deku Tree #4160

Open ThisNekoGuy opened 4 months ago

ThisNekoGuy commented 4 months ago

I noticed that, coming back from the Great Deku Tree after its dungeon, Mido suddenly pops into existence rather than having just been there even if Kokiri LOD is disabled which is supposed to prevent this behavior. (You can even see the girl waaay in the back at the top of the pillar to see that it clearly works as intended for the others, in this instance, but Mido seems to be exempt somehow.

Version: 8.0.5 AppImage OS: SteamOS 3.6.3 (Steam Deck)

Before Screenshot: ![20240518190127_1](https://github.com/HarbourMasters/Shipwright/assets/28468662/fc3bcb81-8753-4b87-853b-b1a88fc818e8)
After Screenshot: ![20240518190135_1](https://github.com/HarbourMasters/Shipwright/assets/28468662/fcb59113-09bf-4ad2-ba99-3db80d49ecad)
boomshroom commented 4 months ago

Looking at the code, after getting the Kokiri Emerald and before talking to Mido again, his draw distance gets set to 100 regardless of the of the setting. It's not that it doesn't check, but that both the path for the setting being set and it being unset conditionally set his draw distance to 100. After talking to him, the draw distance should get set back to 32767 (the draw distance for most things when it's uncapped).