search

HarbourMasters / Shipwright

3.23k stars 488 forks source link

License for crowdcontrol portions. #4183

Open magnusjjj opened 5 months ago

magnusjjj commented 5 months ago

As per https://github.com/HarbourMasters/Shipwright/issues/4023 , I would like to poke people regarding licensing of the crowdcontrol portions. I was wondering if I could work on making it into a library. As for license.. something like CC0 or similar, so you could easily relicense it once the main ship of harkanian figures out what you want to do with it in the future?

So a yes/no on licensing the files under https://github.com/HarbourMasters/Shipwright/tree/develop/soh/soh/Enhancements/crowd-control as CC0, or discussions if you have particular worries or something.

@dcvz @Baoulettes @aMannus @briaguya-ai @garrettjoecox @leggettc18 @Kenix3 @KiritoDv @inspectredc

inspectredc commented 5 months ago

I agree to share all my contributions to HarbourMasters/Shipwright under CC0

magnusjjj commented 5 months ago

I agree to share all my contributions to HarbourMasters/Shipwright under CC0

Sweet. Just a question, did you get an email that you got mentioned in this issue? Not for this comment here, but for the first post. Just want to check in, given that I am not a contributor myself, to check and see if antispam protection might have kicked in. (there is no stress regardless, honestly I was surprised that it let me tag nine people like this).

aMannus commented 5 months ago

I had some small concerns about this code using a lot of the GameInteractor code so the example didn't feel complete, but if it's more as a seperate "in-between" layer, I guess it makes sense only needing the CrowdControl code.

I was not notified by email by the mention because I specifically have them turned off, not sure how others have it set up. I can probably mention some people on our Discord instead to get eyes on this. That said we just had the 2ship2harkinian launch so we're all a bit tired from that, so it could take a little bit of time. All that being said:

I agree to share all my contributions to HarbourMasters/Shipwright under CC0.

magnusjjj commented 5 months ago

I had some small concerns about this code using a lot of the GameInteractor code so the example didn't feel complete, but if it's more as a seperate "in-between" layer, I guess it makes sense only needing the CrowdControl code.

I was not notified by email by the mention because I specifically have them turned off, not sure how others have it set up. I can probably mention some people on our Discord instead to get eyes on this. That said we just had the 2ship2harkinian launch so we're all a bit tired from that, so it could take a little bit of time. All that being said:

I agree to share all my contributions to HarbourMasters/Shipwright under CC0.

Yeah, not taking the interaction code at all, just the layer for CC specifically, I'll write some samples later.

I was just checking, people are more than welcome to be slow as heck. More wanted to check that every could see it.

inspectredc commented 5 months ago

I did get an email, but I don't really check that. I actually just saw this through my GitHub notifications

garrettjoecox commented 5 months ago

I agree to share all my contributions to HarbourMasters/Shipwright under CC0

briaguya-ai commented 5 months ago

I agree to share all my contributions to HarbourMasters/Shipwright under CC0