HarbourMasters / Shipwright

3.18k stars 482 forks source link

make dungeon count number not magic #4196

Open briaguya-ai opened 4 months ago

briaguya-ai commented 4 months ago

we have 12 hardcoded all over the place for dungeon count (especially around cvarSettings[RSK_MQ_DUNGEON_COUNT]), it'd be good to not have that be a magic number and instead #define it somewhere

ganesh1828 commented 4 months ago

Can you please assign this issue? I am already done with the code changes. PR Link - https://github.com/HarbourMasters/Shipwright/pull/4206