search

HarbourMasters / Shipwright

3.1k stars 484 forks source link

Missing Effect when moving Song of Time blocks with Disable LOD #4233

Closed Marcelo20XX closed 1 month ago

Marcelo20XX commented 1 month ago

Whenever you play the Song of Time for moving blocks, the blue effect is missing, here is a video of it:

https://github.com/user-attachments/assets/3f6f20fb-c966-4ea1-9dac-7711f4a4359e

Tested on latest commit: 839fcffe17f00671baa6fb411cba74f42a7b5f5d

on Windows 10, Nvidia 1660 Super on OpenGL backend and latest drivers

Archez commented 1 month ago

I am not experiencing this issue on that commit for both Mac and Windows with Directx/OpenGL/Metal.

Can you include which oot game version you are using that has the missing effect?

DrMaple commented 1 month ago

I am also experiencing this on the latest dev on Windows with OpenGL. Using PAL 1.1. I'm also experiencing weird texture bug with the flesh holes?? in Jabu. I'll make another issue for that when I'm back in my PC but just in case those two things are connected I wanted to mention it here.

Marcelo20XX commented 1 month ago

After pulling the last commit 73be4e55591f547df1a27884fdddbae36f603e07 and using the PAL GC (Debug) or PAL 1.0 rom I am no longer experiencing this issue...

Previously I was using the PAL 1.0 rom with the commit hash of the first post. So I will close the issue as it is solved.

sologuitarplaying commented 1 month ago

After pulling the last commit 73be4e5 and using the PAL GC (Debug) or PAL 1.0 rom I am no longer experiencing this issue...

Previously I was using the PAL 1.0 rom with the commit hash of the first post. So I will close the issue as it is solved.

I still have it on those game versions with https://github.com/HarbourMasters/Shipwright/commit/73be4e55591f547df1a27884fdddbae36f603e07. The yellow light effect when opening large chests is absent as well.

Marcelo20XX commented 1 month ago

No problem on my end, I looted the Big Chest on the Kokiri forest right now containing the Kokiri Sword and the yellow effect showed...

Are you on Windows 10 and using OpenGL?

sologuitarplaying commented 1 month ago

No problem on my end, I looted the Big Chest on the Kokiri forest right now containing the Kokiri Sword and the yellow effect showed...

Are you on Windows 10 and using OpenGL?

Windows 10, no effect on time blocks and large chests on either Directx or OpenGL.

Archez commented 1 month ago

Please discard your oot.otr and oot-mq.otr files and regenerate them, in case you have old ones.

sologuitarplaying commented 1 month ago

They still don't appear after regenerating the otr files. I'll try a clean install. Update: Clean install resolved the issue. Problem was outdated OTR GUI. Update 2: Issue appeared again after changing several enhancement settings. Will try to figure out which one is the cause.

sologuitarplaying commented 1 month ago

Have confirmed that the issue is reproducible by turning on "Disable LOD."

Archez commented 1 month ago

Have confirmed that the issue is reproducible by turning on "Disable LOD."

Ok thank you, that was the piece I was missing. Confirmed on my end as well and I can see the root issue.

sologuitarplaying commented 1 month ago

Have confirmed that the issue is reproducible by turning on "Disable LOD."

Ok thank you, that was the piece I was missing. Confirmed on my end as well and I can see the root issue.

It also prevents the yellow light effect from appearing when opening big chests.

Malkierian commented 1 month ago

Fixed with #4245