search

HarbourMasters / Shipwright

3.31k stars 495 forks source link

Additions and fixes for the German translation in three files #4293

Closed Extloga closed 3 months ago

Extloga commented 3 months ago

This PR contains the initial German translation of hint_list_exclude_dungeon.cpp and hint_list_exclude_overworld.cpp as well as fixes for the German translation in z_select.c combined with very few additional fixes for the English translation and the French one along the way.

I put emphasis on the usage of the old German orthography and the preservation of the original expressions.

Build Artifacts

Extloga commented 3 months ago

A question about the z_select.c file: In the initial German translation of this file, neither Umlaute nor the Eszett were used. Is this file able to process these letters correctly? If that is not the case and one has to use ASCII, I would obviously refrain from correcting these words.

Archez commented 3 months ago

Correct, that file cannot display accented letters.

Malkierian commented 3 months ago

Please rebase or pull in the most recent commits to get Windows building again.

Malkierian commented 3 months ago

@Extloga You don't have to make a new fork every time you want to make another change in a new PR. Just start with develop-rando as a base, and commit to a new branch which you then submit in a PR. Then, you can sync your fork's develop-rando branch and use that as a new base for the next changes.

Extloga commented 3 months ago

@Extloga You don't have to make a new fork every time you want to make another change in a new PR. Just start with develop-rando as a base, and commit to a new branch which you then submit in a PR. Then, you can sync your fork's develop-rando branch and use that as a new base for the next changes.

Thanks for the advice. I am still learning the basics of GitHub and try to keep everything clearly arranged, so I developed a habit to start with a new fork for every single PR, but you are obviously right and I will try to abandon this habit.