search

HarbourMasters / Shipwright

3.3k stars 494 forks source link

automated QA #4387

Closed KatDevsGames closed 1 month ago

KatDevsGames commented 1 month ago

null

Build Artifacts

Malkierian commented 1 month ago

Could we get just a bit of elaboration as to what this is doing?

KatDevsGames commented 1 month ago

the change on line 7 changes use of a deprecated placeholder class that I plan on eventually removing - it has been replaced with the actual non-deprecated class that the deprecated symbol actually references

the change on line 21 prevents the effect list from being regenerated every time the field is read

the changes to the using directives at the top are just removing ones that were totally unused

all other lines are just from running it through the auto code style normalizer thing in resharper

also the submitted file is what I've actually deployed on live crowd control for SoH effective the day I submitted this PR

Malkierian commented 1 month ago

Awesome, thanks.