search

HarbourMasters / Shipwright

3.29k stars 492 forks source link

Regression of LSArchitecturePriority for Apple Silicon #4402

Closed 2600box closed 6 days ago

2600box commented 1 month ago

Hello,

Not sure if this is know, but it seems like this might be a regression? The following is missing from the MacReady .dmg release which is a little ironic. 

    <key>LSArchitecturePriority</key>
    <array>
        <string>arm64</string>
        <string>x86_64</string>

The original issue is this one: https://github.com/HarbourMasters/Shipwright/issues/1553

Adding those values back to the info.plist makes it load the native code from the .app

h678145 commented 1 month ago

It is still there: https://github.com/HarbourMasters/Shipwright/blob/develop/soh/macosx/Info.plist.in, it still loads the native version on MacReady. Edit: it does seem to not be there in develop-macready branch though, so you're correct there. So there aren't any regressions, it just wasn't added by the time that branch was forked off.

Malkierian commented 6 days ago

Closing as stale and won't fix. If it's in develop, then it'll be in the next release. There won't be any more MacReady releases.