Fix some oversights - Githubissues

HarbourMasters / Shipwright

3.3k stars 494 forks source link

Fix some oversights #4405

Closed Pepper0ni closed 1 month ago

Pepper0ni commented 1 month ago

3 1 line changes I found while investigating bean guy issues:

Accidentally used the wrong bean var when deciding if a blue pot from granny should always be in the potion pool
Bean Guy wasn't in what seems to be the save editor's randinf list
Bean guy didn't have an entry in rcToRandomizerInf

Build Artifacts

SuperBro64 commented 1 month ago

Since you are fixing a few issues with the Bean Salesman, perhaps you could also quickly fix a small formatting issue with the "Shuffle Merchants" tooltip, where the "Beans Only" and "All But Beans" settings aren't properly separated out with new lines (screenshot is from the latest develop version):

Malkierian commented 1 month ago

If Pepper0ni wants to, I won't say no, but nothing saying you couldn't make a PR for it yourself. It would undoubtedly be merged very quickly. Also since I might merge this before he gets to it.

SuperBro64 commented 1 month ago

If Pepper0ni wants to, I won't say no, but nothing saying you couldn't make a PR for it yourself. It would undoubtedly be merged very quickly. Also since I might merge this before he gets to it.

Yeah, that makes sense. I mostly suggested it here since I felt it related to the Bean Salesman issues. If this PR gets merged first before that, though, that's fine. I can make a PR myself, as you said.