search

HarbourMasters / Shipwright

3.3k stars 494 forks source link

[Bug] Movement freezes when collecting Gold Skulltula even with "No Skulltula Freeze" turned on #4409

Closed JordanLongstaff closed 1 month ago

JordanLongstaff commented 1 month ago

An apparent regression with the "No Skulltula Freeze" option - it no longer prevents movement freeze like it's supposed to do. It used to work.

https://github.com/user-attachments/assets/aef92eaa-8cde-4e59-90b6-e4414bbccb46

garrettjoecox commented 1 month ago

I knew I broke it but replaced it with the more powerful “skip item cutscenes” toggle, I didn’t remove the checkbox cause I wasn’t sure if we wanted to VB’ify the original feature for vanilla, since the skip item cutscenes doesnt currently work for vanilla.

(then it fell through the cracks)

JordanLongstaff commented 1 month ago

I don't see a "skip item cutscenes" toggle. Is it "skip one point cutscenes"?

garrettjoecox commented 1 month ago

I don't see a "skip item cutscenes" toggle. Is it "skip one point cutscenes"?

It's there in your screenshot, it's just not a checkbox so it's easy to miss

Screenshot 2024-10-14 at 9 08 57 PM
JordanLongstaff commented 1 month ago

Ah, I see. So where are you saying it got broken? When that was introduced? I'm looking at #3755 right now, under the premise that it's the prime suspect, but nothing's sticking out at me as to what broke it.

garrettjoecox commented 1 month ago

Ah, I see. So where are you saying it got broken? When that was introduced? I'm looking at #3755 right now, under the premise that it's the prime suspect, but nothing's sticking out at me as to what broke it.

If you look in the changes in that diff, under soh/src/overlays/actors/ovl_En_Si/z_en_si.c, you can see I removed basically all changes we had made to that file, in favor of the three wrapping GameInteractor_Should's

JordanLongstaff commented 1 month ago

Ah, I see. So where are you saying it got broken? When that was introduced? I'm looking at #3755 right now, under the premise that it's the prime suspect, but nothing's sticking out at me as to what broke it.

If you look in the changes in that diff, under soh/src/overlays/actors/ovl_En_Si/z_en_si.c, you can see I removed basically all changes we had made to that file, in favor of the three wrapping GameInteractor_Should's

Yes, I had found it just before you answered. Sorry I couldn't reply in time. I can't imagine it'd be too difficult to fix.

I don't know what the plan is for the "VB" stuff (stands for Vanilla Behaviour, I'm guessing), but regressions are bad and I propose we patch this until we have a definitive vision for how it should be handled.