search

HarbourMasters / Shipwright

3.3k stars 494 forks source link

Mweep animation speed affected by enhancement #4452

Open JordanLongstaff opened 1 month ago

JordanLongstaff commented 1 month ago

The "King Zora Speed" enhancement now affects the speed of King Zora's mweeping, not just his movement.

Here it is at x5 speed, in all its mweeping glory.

https://github.com/user-attachments/assets/850c3e80-ddf5-4d2c-921a-20e9ab8c2789

Build Artifacts

larsy1995 commented 1 month ago

What the Mweep did I just listen to??

garrettjoecox commented 1 month ago

Is there much benefit to this? It seems like it’s a bit more invasive on the source code and the result looks kind of silly (subjectively)

JordanLongstaff commented 1 month ago

Is there much benefit to this? It seems like it’s a bit more invasive on the source code and the result looks kind of silly (subjectively)

Visual effect. That's it.

I could add a checkbox to control this mod.

Malkierian commented 1 month ago

Hmm, I guess I do agree it's a bit more code invasive than I'd like, but I'm having trouble figuring out how it could be possible in a hook.