search

HarbourMasters / Shipwright

3.29k stars 492 forks source link

VBify poe collector giving for rando. #4458

Closed Malkierian closed 1 month ago

Malkierian commented 1 month ago

Fixes double give for 10 poe reward.

Build Artifacts

Malkierian commented 1 month ago

How does the other end of this work? Don't poes use high scores not a flag?

As far as I know, that's handled by that other block in the previous function. All I changed was the item give.

Malkierian commented 1 month ago

Alright, this is fully hook handled now, virtually full vanilla flow restoration.

Malkierian commented 1 month ago

Also, confirmed vanilla works perfectly, and in rando, if you turn in extras, you just get the rupees.

Malkierian commented 1 month ago

Keep in mind, this skips the whole 1000 point reward string of messages in rando, so if we want to further refine that, I can probably move the hook to 80A2FB40 to let it happen. Would be interested to have feedback on that.

Malkierian commented 1 month ago

Ehhhh, nevermind, that didn't sit right with me. I figured out how to have the message string and still not give vanilla in rando.