search

HarbourMasters / Shipwright

3.27k stars 489 forks source link

Reset command crashes SoH #510

Closed Etn-n closed 2 years ago

Etn-n commented 2 years ago

I'm using the last rando build (#79 or #78 not sure) which seems to be a modified version of Roy Alpha 2.0.0. Anyway, using the command "reset" in the debug console sometimes crashes the game Using it in Link's house (at least as child not tested as adult) seems to be a guaranteed crash. Same with Mido's house. Crashes in Deku Tree too, but not in Kokiri Forest or Lost Woods. I've had it crashing my game in shops and other houses but not everytime, and I'm not sure what's different. All that to say, it crashes and I can't really identify why. Also the command doesn't work on the title screen/file select screen, returns "GlobalCtx == nullptr". Here's one of my log files (where the game crashed) if that can help. Ship of Harkinian.1.log

stratomaster64 commented 2 years ago

For future reference, the reset command modifies some variables within GlobalContext/PlayState to allow you to load the title sequence (from N64 logo). If you attempt to do so at the file select, GlobalCtx doesn't exist and is null, which would crash if the command went through. It's not entirely known why resetting causes crashes in the areas you mentioned, but research of my own indicates there may be some memory corruption somewhere. Hope this helps.

Etn-n commented 2 years ago

Thank you for the info ! :)

briaguya-ai commented 2 years ago

until rando gets merged into dev, issues from rando that haven't been reproduced on dev should stay off github. i'm going to close this for now, if you encounter the same issue on a newer rando build please report it in the #randomizer-playtesting channel on discord.