HausGalerii / Frontend

Haus Gallery frontend
0 stars 0 forks source link

Kunstifilmid (videos page) #4

Open axis-net opened 5 months ago

axis-net commented 5 months ago

Kunst > Kunstifilmid is up and running. Figma: Kunsti filmid (videos main page), Kunsti filmid lahti (videos folder open). There is also article page for a single video to make it possible to share a single video, not just the whole folder. This is missing from figma, but it it can be identical like in the list. Templates: videos.* Socialmedia icons are currently native widgets provided by the portals. I'll look for a solution to custoize them later.

danielaburnaz commented 5 months ago

The <iframe> element for the videos is breaking the site once the width is lower than 560px. Please fix image

danielaburnaz commented 5 months ago

There is also article page for a single video to make it possible to share a single video, not just the whole folder. This is missing from figma, but it it can be identical like in the list.

https://app.asana.com/0/0/1207067724285266 Karola has some suggestions

axis-net commented 5 months ago

Added max-width to iframe and replied to Karola.

danielaburnaz commented 5 months ago

image I worked on videos page and video sharing page

  1. Could you please make it so iframe can grow up to 650px to match the design?
  2. Socialmedia icons are currently native widgets provided by the portals. I'll look for a solution to customize them later. The widgets are also on the artists profile page. Could you please customize them?

axis-net commented 4 months ago

Could you please make it so iframe can grow up to 650px to match the design? #content article .code iframe { width:100%; aspect-ratio:16/9; }

axis-net commented 4 months ago

Socialmedia share buttons added. For this to work a HTML code change is needed: {$_socialmedia.share="facebook":true,"linkedin":true,"x":true,"mail":true}

danielaburnaz commented 4 months ago

image socialmedia.txt (Jaga videot) is missing in desktop view

image I don't know what style the button back (tagasi) should have, is a red border like this good?

axis-net commented 4 months ago

socialmedia.txt (Jaga videot) is missing in desktop view Fixed.

I don't know what style the button back (tagasi) should have, is a red border like this good? Yes, looks good. Also replace "<" with arrow bacground image from some other page and move that button after socialmedia (align with the text).

axis-net commented 3 months ago

Testing

Checkpoints https://haus.ee/test/article.webstandards.testing.en.html

Page http://haus.ee.klient.veebimajutus.ee/?c=kunstifilmid&l=et P7.1 Socialmedia icons are doubled in HTML and visible when CSS not present. Sometimes it could be used as a last resort but why is it necessary here? P7.2 Socialmedia icons get smaller when there are more of them. Set a fixed flex-basis and allow flex-wrap.

Page folder contents http://haus.ee.klient.veebimajutus.ee/?c=kunstifilmid&l=et&t=haus-galerii-sugisoksjon-2023&id=1085 P7.1 Socialmedia icons are doubled in HTML and visible when CSS not present. Sometimes it could be used as a last resort but why is it necessary here? P7.2 Socialmedia icons get smaller when there are more of them. Set a fixed flex-basis and allow flex-wrap. Screenshot 2024-06-08 at 18-48-54 Kunst Kunstifilmid HAUS GALERII SÜGISOKSJON 2023

Page single video http://haus.ee.klient.veebimajutus.ee/?c=kunstifilmid&l=et&id=1092&t=eesti-kunsti-sugisoksjon-2023-johannes-einsild-vaade-puhajarvele-1917 Same as previous.

danielaburnaz commented 3 months ago
  1. P7.1 Socialmedia icons are doubled in HTML and visible when CSS not present. Sometimes it could be used as a last resort but why is it necessary here?

Solved. I removed the doubled

  1. P7.2 Socialmedia icons get smaller when there are more of them. Set a fixed flex-basis and allow flex-wrap.

Solved.