Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

NextJS Views Implementation #680

Open AndyRae opened 1 month ago

AndyRae commented 1 month ago

Summary

The frontend UI is incrementally adopting Nextjs, replacing the existing Django / React views.

Tracking issue for implementing the following views in Nextjs:

In order of general priority, as high traffic / fixing bugs.

*Do users want the current Home? Should home actually be the list of Scan Reports.

spco commented 1 month ago

NextJS noob question: can we make all of these paginated/supporting pagination by default (some of course will typically be short enough to not require pagination)?

AndyRae commented 1 month ago

That's exactly the plan - we're adding pagination, filtering, sorting where necessary.

spco commented 1 month ago

May want to add Scan Report Rules "Summary" modal.

Note that the Analyse Rules modal requires a lot of compute, and we may wish to rethink much of that in light of the sizes of data we're currently handling.

And note that Assertions is a vestigial organ from the NLP work. Unless we are planning to bring back the NLP work soon, I'd suggest we in fact remove that functionality rather than renew the view.

AndyRae commented 1 month ago

May want to add Scan Report Rules "Summary" modal.

Thanks! I thought we might miss some... think I this mixed up a bit with Analyse in retrospect now.

Note that the Analyse Rules modal requires a lot of compute, and we may wish to rethink much of that in light of the sizes of data we're currently handling.

A quick glance looks like this could be served by a function also, with a similar model.

And note that Assertions is a vestigial organ from the NLP work. Unless we are planning to bring back the NLP work soon, I'd suggest we in fact remove that functionality rather than renew the view.

Excellent!