Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

Allow upload of large WhiteRabbit Scan reports #612

Closed PhilAppleby closed 2 months ago

PhilAppleby commented 5 months ago

The upload function times-out for large scan reports.

For example, for the UoD SHARE dataset - more detail will be supplied in comments

spco commented 5 months ago

More definition/examples of "large" are required. #tables, #fields, #values, #reused mappings, or #vocab-mapped values. All of these should ideally be handled by CaRROT-Mapper, but examples are needing for testing.

AndyRae commented 5 months ago

I think there are 3 things we can do here:

AndyRae commented 4 months ago

As discussed, we're continuing with our work to split out the Scan Report fields "upload" from the Concept "processing". Our first iteration of this to come soon will continue with the existing UI, but the Scan Report will be uploaded in the UI, with no processing taking place. We will then create Concepts per table (and get the reusable Concepts) when the user selects their "Person ID" and "Date Event" for the table, and selects: "Update Table".

After that, we can either put effort into:

  1. Make this upload and processing faster, directly using the Django ORM rather than the REST API.
  2. Design the UX into a multi step form to support uploading a Scan Report. Currently our outlined temporary UX means still having to traverse the UI to upload, select their table details and so on. Ideally we want this encapsulated into a supported form to guide the user through, with the option for #623 also. And then allow for viewing more detailed logs and status of the upload/process. With ultimately removing the "Refresh Rules" button also in #617