Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

White Rabbit Scan report: Avoid manual reformatting of "Field Overview" data #613

Open PhilAppleby opened 5 months ago

PhilAppleby commented 5 months ago

CaRROT-Mapper currently requires manual edits in the Scan report "Field Overview" sheet. (Fraction empty | N unique values | Fraction unique) need changes before upload. Details in comments

spco commented 5 months ago

Agreed. We don't make any use of these fields, and so should probably remove all treatment of them. This would require agreement that we truly won't need these fields now or in future (Type, Max length, N rows, N rows checked, Fraction empty, N unique values, Fraction unique), before removing the ingestion code and then either deleting the existing values from the DB, or making them optional.