Health-Informatics-UoN / Carrot-Mapper

Convenient And Reusable Rapid Omop Transformer.
https://carrot.ac.uk
MIT License
14 stars 3 forks source link

Vocabulary / mapping versioning #624

Open PhilAppleby opened 8 months ago

PhilAppleby commented 8 months ago

The vocabulary tables used by CaRROT-Mapper should be updated regularly.

Existing mappings should be left as they are, but should we consider highlighting anomalies? Obsolete = Greyed out, non-standard = Red, for example.

spco commented 8 months ago

Proposal from @erummas that mapping rules to obsolete concepts remain until the user chooses to remap or refresh the SR. With vocabulary updates, Concepts are never removed, but moved to non-valid, or their valid dates are set to expire. So their links should remain working, but not available for new mapping.

@erummas @PhilAppleby I know that sometimes Concepts move between domains, particularly those that have recently been added. Do they keep their same Concept Number during that move, or is the existing one retired and a new one made in the new domain?

AndyRae commented 6 months ago

The vocabularies have been updated in #631 (and we can do so much more frequently now), we'll leave this open as there is work to do about making it clear to users about existing mappings as mentioned.