Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

Creating a new Dataset without assigning it to a Project places it in all Projects #651

Closed spco closed 18 hours ago

spco commented 3 months ago

Is there an existing issue for this?

Current Behavior

Creating a new Dataset without assigning it to a Project places it in all Projects.

Expected Behavior

The form should show an error and refuse to create the Dataset until at least one Project is created.

Steps To Reproduce

This was replicated on the dev system below:

image

After selecting "Add new Dataset", the Project is added to all Projects (or possibly all the Projects the user is in - I've not been able to very).

image

Environment

- OS:
- Other environment details:

I'm part of a Project Team

No response

Anything else?

No response

Are you willing to contribute to resolve this issue?

🎨 Yes, I'm keen to be involved in design discussions.

spco commented 3 months ago

Also to note: on the Dataset Details page, a Dataset can have all of its Projects removed. It then becomes unviewable. This shouldn't be possible - the Dataset Details page should error if attempting to remove the last Project from a Dataset.

AndyRae commented 4 days ago

Should be fixed in #774