search

Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

Merge dev to prod 2.0.14 #655

Closed AndyRae closed 3 months ago

AndyRae commented 3 months ago

Follow #645 to deploy new pipelines.

Relevant to #639

github-actions[bot] commented 3 months ago
Tests Skipped Failures Errors Time
25 1 :zzz: 0 :x: 0 :fire: 1.629s :stopwatch:
github-advanced-security[bot] commented 3 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

spco commented 3 months ago

Is there a reason for skipping the test branch (we normally do devel -> test -> master), or is it purposeful, given the deployment changes?

AndyRae commented 3 months ago

Is there a reason for skipping the test branch (we normally do devel -> test -> master), or is it purposeful, given the deployment changes?

There's no benefit to it now really - as we're essentially making devel and test redundant as branches, as they don't have workflows that deploy from them anymore.

Once this is merged into master, it will deploy to dev, and have an approval process to deploy to test, and then to production.

But I now realise, that there could be code that has been merged into dev -> test but not into master yet, so we would be skipping it in this case. I'll double check we're not leaving anything behind.