Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.

https://carrot4omop.ac.uk

MIT License

12 stars 3 forks source link

Fix reusing Concepts without a data dictionary #672

Closed AndyRae closed 2 months ago

AndyRae commented 2 months ago

Changes

Fixes a bug introduced in #643, and half fixed in #661.

Currently when a data dictionary is not supplied with a Scan Report, the two functions mark this as a "None" string, or a None type. So we now safely catch for both cases. At some point stronger typing will help prevent these!

Also fixes the functions build from #671

Checks

Important: please complete these before merging.

[x] Run migrations, if any.
[x] Update changelog.md, including migration instructions if any.
[x] Run unit tests.

github-actions[bot] commented 2 months ago

Tests	Skipped	Failures	Errors	Time
25	1 :zzz:	0 :x:	0 :fire:	2.404s :stopwatch: