Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

Fields with large number of values are not loading #677

Closed erummas closed 1 month ago

erummas commented 2 months ago

Is there an existing issue for this?

Current Behavior

Currently the large scan reports are uploading with no errors, however fields with large number of values show 'loading values' status and then the page stops responding.

Expected Behavior

Show all the field values

Steps To Reproduce

Scan report # 620 Table : share_gp_data.csv Field: NewRead

Environment

- OS:
- Other environment details:

I'm part of a Project Team

No response

Anything else?

No response

Are you willing to contribute to resolve this issue?

None

spco commented 2 months ago

Thanks @erummas we'll look into it.

For our future reference, that field has 29244 unique values, (not dates or person IDs or anything).

This will need to be fixed via pagination improvements, unless Andy can work some other magic in the interim.

AndyRae commented 2 months ago

Yes I agree - this will have to be enabled by pagination. Good to know we can handle the large reports though.

AndyRae commented 1 month ago

Will be fixed by #681