Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

🐛 CSV rules output needs a further change #678

Closed PhilAppleby closed 1 month ago

PhilAppleby commented 2 months ago

Is there an existing issue for this?

Current Behavior

The new format for csv output has introduced an error - the 'domain' column contains target field and domain is not present in the output records.

Expected Behavior

The domain column should contain OMOP domain and OMOP target field should be present in a 'target_field' column which will have to be added / re-instated

Steps To Reproduce

No response

Environment

- OS:
- Other environment details:

I'm part of a Project Team

No response

Anything else?

No response

Are you willing to contribute to resolve this issue?

None

spco commented 2 months ago

Yup - this is due to #653. In that, destination_field has been incorrectly used for domain information. It should be using destination_table instead. destination_field needs to returned under its own heading (this is the euaivalen tof target_table above).

This doesn't affect the rendering of the rules webpage, but is also confusing for the future there.