search

Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

Mapper not generating rules for value_as_number in the observation domain #711

Open erummas opened 1 month ago

erummas commented 1 month ago

Issue value_as_number is the field that records numeric value(s) of the source field or source field value(s) mapped to a concept_id in Measurement and Observation Domain. This is working perfectly fine for Measurement but not Observation. I believe this was not always the case, however, I have just noticed it

To reproduce Go to scan report # 623 check mapping against concept 35815526 - Age at event

Environment

- OS:
- Other environment details:

I'm part of a Project Team

No response

Anything else?

No response

Are you willing to contribute to resolve this issue?

None

AndyRae commented 1 month ago

Thanks Erum - we will investigate.

AndyRae commented 1 month ago

Relevant: https://github.com/Health-Informatics-UoN/CaRROT-Mapper/blob/7032dff83bfbb5d896ca2e3845ad82c5e76efd92/app/shared/shared/services/rules.py#L371

Given there is direct code for the measurement domain, and nothing for the observation domain, my initial thinking is that this is not a regression. But will take a further look.