Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

💡 Filter fields and field values on their mapping status #725

Open erummas opened 1 month ago

erummas commented 1 month ago

Is there an existing issue for this?

Is your proposal related to a problem or functionality gap?

Currently we see all fields and field values in the scan report. For larger scan reports, sometimes it gets difficult to check and validate if all values have been mapped (especially when mapping manually) and are correct.

Describe your proposal

I think it would be very helpful if we can get a filter on with the following options

  1. mapped,
  2. unmapped
  3. automatically mapped
  4. manually mapped
  5. reusable mapped

fields and field values

Describe alternatives you've considered

No response

I'm part of a Project Team

No response

Anything else?

No response

Are you willing to contribute to developing this feature?

None

AndyRae commented 1 month ago

Yes I can see how this would be very useful.

In terms of UI, we'd probably implement it like the Status filtering on the new Scan Report list page:

Screenshot 2024-05-28 at 12 40 18

But with your list of options instead.

From a technical point of view - this will be tricky, as my understanding is we don't know those options when we first fetch the fields/values, we only know when we fetch the scan report concepts. So maybe we just add the filtering at that point instead.

spco commented 1 month ago

Really good suggestion. Agree with the question about how we might filter in practice. In particular, with the mapped/unmapped options, given we can have multiple concepts per value/field, that's more of a filter on the values/fields themselves, rather than the scan report concepts.