Health-Informatics-UoN / Carrot-Mapper

Carrot: Convenient And Reusable Rapid Omop Transformer.
https://carrot4omop.ac.uk
MIT License
12 stars 3 forks source link

Fix fetching Concepts to be conditional #775

Closed AndyRae closed 1 day ago

AndyRae commented 4 days ago

Changes

Fixes fetching Scan Report Concepts at Scan Reports Fields/Values page level, to be conditional based on if fields/values exist. The issue was that if no fields/values existed, Concepts would still be fetched without the filtering, resulting in long running queries. A few of these in succession (for example, through revalidation) could slow the API down to a halt.

Additionally adding pagination to the endpoints used, and therefore updating the client to fetch all pages where necessary. We will probably now upgrade any unpaginated endpoint to a v2 with pagination, this is a general concern across every endpoint.

Additionally adds a Forbidden layout - if the user does not have permission to see the Scan Report.

Related #761

Checks

Important: please complete these before merging.

github-actions[bot] commented 4 days ago
Tests Skipped Failures Errors Time
25 1 :zzz: 1 :x: 0 :fire: 4.337s :stopwatch: