Health-Informatics-UoN / Carrot-Mapper

Convenient And Reusable Rapid Omop Transformer.
https://carrot.ac.uk
MIT License
14 stars 4 forks source link

Concept reuse conflicts ICD10 codes #902

Open erummas opened 5 hours ago

erummas commented 5 hours ago

Is there an existing issue for this?

Current Behavior

Hello, I have observed that the concept reuse is not working fine on the ICD10 codes. sharing screenshots for only two cases Image In the image above the automated concept_id generated is incorrect (red) and only one of the reuse one is correct(blue)

Image In the above image the reuse concept id is incorrect and only the automated one is correct

ScanReport No. 701

Expected Behavior

Show only valid mappings

Steps To Reproduce

No response

Environment

I'm part of a Project Team

No response

Anything else?

No response

Are you willing to contribute to resolve this issue?

None

AndyRae commented 5 hours ago

Thanks @erummas, we'll investigate.

For image .2 - a quick look is that we had a test Scan Report that implemented that rule, and was being reused, I've turned this off now. But this is obviously a general concern of ours, as currently effectively one Scan Report poisons the well... so some of our upcoming work will prevent this with more control of what mappings are reused from where.

Image .1 might be the same, but I want to check.