search

HeimgardTechnologiesAS / cordova-plugin-advanced-websocket

MIT License
27 stars 18 forks source link

wsClose optional arguments currently not optional (no onClose event & iOS crash) #13

Open elgerlambert opened 5 years ago

elgerlambert commented 5 years ago

The docs state that the second and third arguments (code & reason) of wsClose are optional. If omitted however no "onClose" event is sent and iOS crashes.

If the code & reason are included it works as expected.

chax commented 5 years ago

I think you're right. Good catch. I can make them optional (with default values).