HelikarLab / candis

:ribbon: A data mining suite for gene expression data.
http://candis.readthedocs.io
GNU General Public License v3.0
27 stars 25 forks source link

Solves issue#37 candis not running on docker #167

Closed promehul closed 5 years ago

promehul commented 5 years ago
Explanation About What Code Achieves:
Screenshots/GIFs:

image

Steps To Test:

-Run it.

TODOs:
promehul commented 5 years ago

Tests on this PR failed with error messages "no environment variables set". I am not able to get what I did wrong !!

promehul commented 5 years ago

Then merge it if you find it correct!!

achillesrasquinha commented 5 years ago

I don't think this is a good idea of providing the service name as a default. It should be localhost.

achillesrasquinha commented 5 years ago

Your service name should be overriden by environment variables passed into your docker service.

achillesrasquinha commented 5 years ago

Closing this.

promehul commented 5 years ago

@achillesrasquinha please check now if its what you asked for.

rupav commented 5 years ago

@promehul are you still facing that refresh problem - pipeline not saving in db on refreshing?

promehul commented 5 years ago

image Its getting saved in db but it is not getting displayed ON REFRESH !! @rupav

rupav commented 5 years ago

just created a pipeline named 'pilot', logged out, logged in back pipeline is still present. Refreshed, then logged in, and again found the pipeline correctly. Screenshot from 2019-03-20 21-33-57

rupav commented 5 years ago

Please check again, and let us know. Install a screen recorder (like 'peek'), to record the flow of the app, and thus the error you are facing, post the gif here when you are done.

promehul commented 5 years ago

@rupav are you running it on docker or using get_candis script? I followed the same steps that you followed .

rupav commented 5 years ago

One error found in the flow so far, forgot password functionality. That's a seperate issue, because of Gmail auth of our mail server. Except this, try finding other issues in docker setup @promehul . I am running it on docker @promehul using your changes.

promehul commented 5 years ago

If it is running all fine, then please merge my PR.

promehul commented 5 years ago

test @rupav I did this

rupav commented 5 years ago

You have to open the existing file, not creating new. How can it create new with the same name, rather try opening the existing file. All works fine then.

rupav commented 5 years ago

This is the correct behavior of the app, if pipe with same name exists, you cant create one, and thus the warning.

rupav commented 5 years ago

try clicking on 'open' instead of 'new' after refreshing the browser, once you have created 'qwerty' pipe.

promehul commented 5 years ago

Thanks @rupav

promehul commented 5 years ago

This has been open for 9 days. Any follow up? @rupav

rupav commented 5 years ago

Did you @promehul try running the pipeline on docker? Are you able to populate the 'file' (by creating new file) with CEL files? If so, please explain how so. Refer Readme GIF, for checking how to run the pipeline.