search

HexHive / retrowrite

RetroWrite -- Retrofitting compiler passes through binary rewriting
Other
655 stars 78 forks source link

naming issue of global symbols #15

Closed junxzm1990 closed 11 months ago

junxzm1990 commented 3 years ago

Please consider changing the code at https://github.com/HexHive/retrowrite/blob/master/librw/loader.py#L196

The statement here will change the name of global symbols to "original_name_address". For instance, this will change "symbol1" (whose address is 0x90) to "symbol1_90" and keep the new name all the way to the assembly file. However, the other references to the symbol in the code or data will still use the original name. Re-assembling will complain "undefined symbol1_90".

cyanpencil commented 3 years ago

Hi, thank you for taking the time to fill the issue. Could you provide us with a proof of concept binary that fails reassembly this way?

gannimo commented 11 months ago

No update received, therefore closing the issue