The value for cargoAccuracy is stored as a key called result in an object, whereas defenseQuantity is stored directly as the value.
Preferred format:
Since the overview page only shows one value for each metric, I would prefer if all of the metrics followed the format of defenseQuantity and defenseQuality.
The average for defenseQuantity is stored under defenseQuantityAverage whereas the average for defenseQuality is stored under defenseQualityAverage. While this is logical, it is not necessary as the response is linked to the request which already includes it.
Preferred format:
{
"value": 0,
"valueMatches": [
0,
0,
0
],
// Other data from #9
}
In these situations, much more code on the dashboard app could be reused if each used the same format.
Right now, the names of data in overview an metric responses don't follow a specific convention.
Examples
cargoAccuracy
inoverview
defenseQuantity
inoverview
The value for
cargoAccuracy
is stored as a key calledresult
in an object, whereasdefenseQuantity
is stored directly as the value.Preferred format: Since the overview page only shows one value for each metric, I would prefer if all of the metrics followed the format of
defenseQuantity
anddefenseQuality
.defenseQuantity
resultdefenseQuality
resultThe average for
defenseQuantity
is stored underdefenseQuantityAverage
whereas the average fordefenseQuality
is stored underdefenseQualityAverage
. While this is logical, it is not necessary as the response is linked to the request which already includes it.Preferred format:
In these situations, much more code on the dashboard app could be reused if each used the same format.
Edit: updated with preferred formats